Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-sync with internal #29778

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Re-sync with internal #29778

merged 1 commit into from
Aug 26, 2020

Conversation

bigfootjon
Copy link
Member

@bigfootjon bigfootjon commented Aug 26, 2020 •
edited
Loading

fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2

@bigfootjon
Re-sync with internal
96b44fc 
fbshipit-source-id: 3ab0a301e1acbb90408ef22bafe2cc1e3aa46161
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 26, 2020
shergin
shergin approved these changes Aug 26, 2020
View reviewed changes
ReactCommon/jsi/jsi/test/testlib.cpp
"pho",
Object::createFromHostObject(rt, std::make_shared<ProtoHostObject>()));

EXPECT_EQ(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this code tests that we can use HostObjects as object prototypes.
Seems legit but I don't understand what's the point to use Symbol.toPrimitive here, we can use any symbol here.

@bigfootjon bigfootjon merged commit fd691d8 into master Aug 26, 2020
@bigfootjon bigfootjon deleted the sync-with-internal branch August 26, 2020 17:25
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 1270873

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,029,251 0
android hermes armeabi-v7a 6,693,203 0
android hermes x86 7,449,584 0
android hermes x86_64 7,340,459 0
android jsc arm64-v8a 9,187,808 0
android jsc armeabi-v7a 8,843,909 0
android jsc x86 9,036,223 0
android jsc x86_64 9,613,305 0

Base commit: 1270873

@bigfootjon bigfootjon restored the sync-with-internal branch August 26, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@shergin shergin shergin approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fh:direct-merge-enabled p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bigfootjon @analysis-bot @shergin @rickhanlonii @facebook-github-bot