Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default metro.config.js to utilize inline requires #29770

Closed
wants to merge 2 commits into from
Closed

Change default metro.config.js to utilize inline requires #29770

wants to merge 2 commits into from

Commits on Aug 26, 2020

  1. RNTester UI Redesign (facebook#29685) 

    Summary:
This Pull request adds the UI changes to the RNTester app as discussed in the MLH Fellowship.

## Changelog

This list is not exhaustive.

- The initial App screen is redesigned.
  - A bottom Navbar has been added.
   - Filter pills are added.
   - The list card UI is updated.

- The example page UI is updated.

- Recently Viewed Sections are added. It shows the last 5 recently viewed components/APIs.

- Bookmarking functionality is added.

- The documentation URL is added to the example page.

- RNTester doesn't lose its state on a hard refresh (even on iOS).

# Screenshots

<img width="373" src="https://user-images.githubusercontent.com/22813027/90530113-20346180-e192-11ea-8ef6-789fa25b402b.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530112-20346180-e192-11ea-9539-706b540fcc5f.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530100-1d397100-e192-11ea-8836-b88070643233.png" />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530110-1f9bcb00-e192-11ea-936b-64ee75fa4289.png" />

Pull Request resolved: facebook#29685

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

# Tested RNTester in Catalyst

{F302717939}

# Tested in RNTester in Facebook

Note: this failed **before** this diff too:

{F302745716}

Reviewed By: mdvacca, cpojer

Differential Revision: D23240434

fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2
    @anku255 @facebook-github-bot
    anku255 authored and facebook-github-bot committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    549e5a8 View commit details
    Browse the repository at this point in the history

  2. Change default metro.config.js to utilize inline requires 

    This feature has been in experimental mode since 0.59.0
    @GantMan
    GantMan authored Aug 26, 2020
    Configuration menu
    Copy the full SHA
    83efc70 View commit details
    Browse the repository at this point in the history