Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-config): Update eslint-plugin-react-hooks #29299

Closed

Conversation

radko93
Copy link
Contributor

@radko93 radko93 commented Jul 8, 2020

Summary

This version of eslint-plugin-react-hooks fixes issues with combining optional chaining and hooks facebook/react#19243 (comment). New users will benefit from this directly, but if someone has 4.0.4 or 4.0.5 in his lockfile he might not get it, so I think we should release a minor version bump for this.

Changelog

[Internal] [Fixed] - Updated eslint-plugin-react-hooks in eslint config

Test Plan

No test plan required.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: cfa4260

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,764,990 0
android hermes armeabi-v7a 6,427,925 0
android hermes x86 7,152,623 0
android hermes x86_64 7,042,550 0
android jsc arm64-v8a 8,936,316 0
android jsc armeabi-v7a 8,591,663 0
android jsc x86 8,767,077 0
android jsc x86_64 9,342,614 0

Base commit: cfa4260

@radko93 radko93 closed this Jul 13, 2020
@radko93 radko93 deleted the fix/eslint-config-react-hooks branch July 13, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants