Migrate Animated module to universal react-animated package #28892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why Make it possible to use the universal Animated package without installing all of React Native. Popular packages like `react-native-web` and `react-spring` both vendor React Animated in order to use it while maintaining a reasonable bundle size. # How Move `Libraries/Animated` to `packages/react-animated` and make `react-native` depend on `react-animated`.
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Popular packages like
react-native-webandreact-springboth vendorreact-native's Animated module in order to use it in the browser while maintaining a reasonable bundle size. This change makes it possible to use the universal Animated module in any React project without installing all of React Native.react-nativeshouldn't change at all.Libraries/NativeAnimationpackage intoreact-animatedtoo.Changelog
[General] [Added] - Refactor
Libraries/Animatedintoreact-animatedand makereact-nativedepend onreact-animated[General] [Removed] - Removed
Libraries/Animated-- this breaks any import that reaches into the internals of Animated likereact-native/Libraries/Animated/*.Test Plan
TBD -- this PR is currently conceptual, will implement tests after further discussions.
@cpojer thoughts on how versioning could work with the package here?