Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fixes TextInput shaking when typing Chinese #28805

Closed
wants to merge 4 commits into from
Closed

[iOS] Fixes TextInput shaking when typing Chinese #28805

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c392ff
[iOS] Fixes TextInput shaking when typing Chinese
zhongwuzw May 2, 2020
b3224ff
Move check to concrete class of backTextInputView
zhongwuzw May 3, 2020
5a20e81
Update RCTUITextField.m
shergin May 4, 2020
53f2b0c
Update RCTUITextView.m
shergin May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Libraries/Text/TextInput/RCTBaseTextInputView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ - (void)enforceTextAttributesIfNeeded
if ([textAttributes valueForKey:NSForegroundColorAttributeName] == nil) {
[textAttributes setValue:[UIColor blackColor] forKey:NSForegroundColorAttributeName];
}
// We need to add check here.See https://github.com/facebook/react-native/issues/28488
zhongwuzw marked this conversation as resolved.
Show resolved Hide resolved
if ([backedTextInputView.defaultTextAttributes isEqualToDictionary:textAttributes]) {
return;
}

backedTextInputView.defaultTextAttributes = textAttributes;
}
Expand Down