-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BackHandler: specify function return type for handler #28192
Conversation
RNTester (Android/hermes/arm64-v8a): 3291136 bytes |
RNTester.app (iOS): 10657792 bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙆♂
Base commit: 25793ea |
@TheSavior Can you merge this? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Base commit: 25793ea |
This pull request was successfully merged by @Naturalclar in a903d1b. When will my fix make it into a release? | Upcoming Releases |
Summary
Following the comment DefinitelyTyped/DefinitelyTyped#42618 (comment)
Modify the flowtype of BackHandler function to have more specific return type.
Changelog
[General] [Changed] - Changed type of BackHandler to be more specific.
Test Plan
No flow error in RNTester