Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibilityValue prop on Touchables #26752

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Libraries/Components/Touchable/TouchableBounce.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ const TouchableBounce = ((createReactClass({
accessibilityState={this.props.accessibilityState}
accessibilityActions={this.props.accessibilityActions}
onAccessibilityAction={this.props.onAccessibilityAction}
accessibilityValue={this.props.accessibilityValue}
nativeID={this.props.nativeID}
testID={this.props.testID}
hitSlop={this.props.hitSlop}
Expand Down
1 change: 1 addition & 0 deletions Libraries/Components/Touchable/TouchableHighlight.js
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@ const TouchableHighlight = ((createReactClass({
accessibilityHint={this.props.accessibilityHint}
accessibilityRole={this.props.accessibilityRole}
accessibilityState={this.props.accessibilityState}
accessibilityValue={this.props.accessibilityValue}
accessibilityActions={this.props.accessibilityActions}
onAccessibilityAction={this.props.onAccessibilityAction}
style={StyleSheet.compose(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ const TouchableNativeFeedback = createReactClass({
accessibilityState: this.props.accessibilityState,
accessibilityActions: this.props.accessibilityActions,
onAccessibilityAction: this.props.onAccessibilityAction,
accessibilityValue: this.props.accessibilityValue,
children,
testID: this.props.testID,
onLayout: this.props.onLayout,
Expand Down
1 change: 1 addition & 0 deletions Libraries/Components/Touchable/TouchableOpacity.js
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ const TouchableOpacity = ((createReactClass({
accessibilityState={this.props.accessibilityState}
accessibilityActions={this.props.accessibilityActions}
onAccessibilityAction={this.props.onAccessibilityAction}
accessibilityValue={this.props.accessibilityValue}
style={[this.props.style, {opacity: this.state.anim}]}
nativeID={this.props.nativeID}
testID={this.props.testID}
Expand Down
4 changes: 4 additions & 0 deletions Libraries/Components/Touchable/TouchableWithoutFeedback.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import type {
AccessibilityState,
AccessibilityActionInfo,
AccessibilityActionEvent,
AccessibilityValue,
} from '../View/ViewAccessibility';

type TargetEvent = SyntheticEvent<
Expand All @@ -55,6 +56,7 @@ const OVERRIDE_PROPS = [
'accessibilityState',
'accessibilityActions',
'onAccessibilityAction',
'accessibilityValue',
'hitSlop',
'nativeID',
'onBlur',
Expand All @@ -71,6 +73,7 @@ export type Props = $ReadOnly<{|
accessibilityRole?: ?AccessibilityRole,
accessibilityState?: ?AccessibilityState,
accessibilityActions?: ?$ReadOnlyArray<AccessibilityActionInfo>,
accessibilityValue?: ?AccessibilityValue,
children?: ?React.Node,
delayLongPress?: ?number,
delayPressIn?: ?number,
Expand Down Expand Up @@ -112,6 +115,7 @@ const TouchableWithoutFeedback = ((createReactClass({
accessibilityState: PropTypes.object,
accessibilityActions: PropTypes.array,
onAccessibilityAction: PropTypes.func,
accessibilityValue: PropTypes.object,
/**
* When `accessible` is true (which is the default) this may be called when
* the OS-specific concept of "focus" occurs. Some platforms may not have
Expand Down
8 changes: 5 additions & 3 deletions RNTester/js/examples/Accessibility/AccessibilityExample.js
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ class FakeSliderExample extends React.Component {
}}>
<Text>Fake Slider</Text>
</View>
<View
<TouchableWithoutFeedback
accessible={true}
accessibilityLabel="Equalizer"
accessibilityRole="adjustable"
Expand All @@ -588,8 +588,10 @@ class FakeSliderExample extends React.Component {
}
}}
accessibilityValue={{text: this.state.textualValue}}>
<Text>Equalizer</Text>
</View>
<View>
<Text>Equalizer</Text>
</View>
</TouchableWithoutFeedback>
</View>
);
}
Expand Down