Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/revamp rn tester #25746

Closed

Conversation

satheeshwaran
Copy link

@satheeshwaran satheeshwaran commented Jul 20, 2019

Summary

Revamp of RNTester.
Removed non-core components for Android that will be moved to react-native-community soon.
Fixed status bar style in iOS for the first launch.
Removed non-core components for iOS that will be moved to react-native-community soon.

Changelog

[General] [Deprecated] - Removed non-core components from RNTester for Android & iOS

Test Plan

  • Tested the RNTester app after changes.
  • Fixed all unit tests that might fail after this change.

Screenshots

iOS

Simulator Screen Shot - iPhone X - 2019-07-20 at 20 49 45

Android

Screenshot_1563628168

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 20, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cpojer
Copy link
Contributor

cpojer commented Jul 24, 2019

Thank you for your PR. I would prefer to keep these examples around until we remove each individual component which we can only do from Facebook's side.

Would you mind changing your PR to only include the status bar change? Thank you!

@cpojer
Copy link
Contributor

cpojer commented Aug 13, 2019

Closing due to inactivity. Please create a new PR if you have time to get back to this with the feedback from me.

@cpojer cpojer closed this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Type: Deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants