Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for AsyncStorage #23384

Closed
wants to merge 2 commits into from

Conversation

krizzu
Copy link

@krizzu krizzu commented Feb 11, 2019

Summary

Added a deprecation warning for the Async Storage, module as part of #23313.

Changelog

[General] [Deprecated] - Async Storage was moved to community repo

Test Plan

RNTester will display a warning when importing AsyncStorage

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 11, 2019
@krizzu krizzu changed the title add deprecation warning Deprecation warning for AsyncStorage Feb 11, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

@@ -192,6 +192,12 @@ module.exports = {
return require('AppState');
},
get AsyncStorage() {
warnOnce(
"async-storage-moved",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace "async-storage-moved" with 'async-storage-moved'

@@ -192,6 +192,12 @@ module.exports = {
return require('AppState');
},
get AsyncStorage() {
warnOnce(
"async-storage-moved",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quotes: Strings must use singlequote.

@@ -192,6 +192,12 @@ module.exports = {
return require('AppState');
},
get AsyncStorage() {
warnOnce(
"async-storage-moved",
"Async Storage has been extracted from react-native core and will be removed in a future release. " +

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace "Async·Storage·has·been·extracted·from·react-native·core·and·will·be·removed·in·a·future·release.·" with 'Async·Storage·has·been·extracted·from·react-native·core·and·will·be·removed·in·a·future·release.·'

@@ -192,6 +192,12 @@ module.exports = {
return require('AppState');
},
get AsyncStorage() {
warnOnce(
"async-storage-moved",
"Async Storage has been extracted from react-native core and will be removed in a future release. " +

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quotes: Strings must use singlequote.

warnOnce(
"async-storage-moved",
"Async Storage has been extracted from react-native core and will be removed in a future release. " +
"It can now be installed and imported from '@react-native-community/async-storage' instead of 'react-native'. " +

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Insert ··

"async-storage-moved",
"Async Storage has been extracted from react-native core and will be removed in a future release. " +
"It can now be installed and imported from '@react-native-community/async-storage' instead of 'react-native'. " +
"See https://github.com/react-native-community/react-native-async-storage for more informations.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace "See·https://github.com/react-native-community/react-native-async-storage·for·more·informations." with ··'See·https://github.com/react-native-community/react-native-async-storage·for·more·informations.'

"async-storage-moved",
"Async Storage has been extracted from react-native core and will be removed in a future release. " +
"It can now be installed and imported from '@react-native-community/async-storage' instead of 'react-native'. " +
"See https://github.com/react-native-community/react-native-async-storage for more informations.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quotes: Strings must use singlequote.

@krizzu krizzu force-pushed the deprecate-asyncStorage branch from 0c14969 to 9967baa Compare February 11, 2019 16:30
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 11, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@krizzu merged commit ffe3748 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 11, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 11, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants