[Pushnotifications] Add error event

[DannyvanderJagt]

This PR will add an error event to PushNotificationIOS.

How it works
When something goes wrong with the Push notifications, for example running on a simulator or when the certificates aren't configured the right way, IOS will create an error and pass it to didFailToRegisterForRemoteNotificationsWithError. This error consists out of an key and a message. This error is passed down from IOS to Js and when there is an error event registered in JS it will pass the error. When there isn't an error event registered nothing will happen.

Why is this useful?
At the moment PushNotificationIOS fails silently and there is no way of telling if something went wrong. Therefore some people are having trouble to get push notifications working in react-native.

How to use
The error event can be used just like the register and the notification event.
The error callback will give the error message and the error key. Both are the original IOS error.

// Javascript:
PushNotificationIOS.addEventListener('error', function(message, key){
   console.log('An error occurred: ', message);
});
PushNotificationIOS.addEventListener('register', function(token){
   console.log('You are registered and the device token is: ',token)
});
PushNotificationIOS.requestPermissions();

And add this to the AppDelegate.m besides the normal pushnotifications code:

- (void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error
{
  [RCTPushNotificationManager application:application didFailToRegisterForRemoteNotificationsWithError:error];
}

Similar PR
A similar solution PR exists: #1019
This PR uses a callback as a parameter in requestPermissions and it will give you a token or an error.
I prefer the solution is this PR because it is:

• more in line with the react-native Api.
• less potential spaghetti code
• I have used this in an proof of concept app and I prefer the event over the callback.

References
This PR was part of #1979 and it is discussed here: #1613.

This event should be added to the docs. Can anyone tell me how accomplish this?

Please let me know what you think.

[PhilippKrone]

@ide Do you have any information here about whether this is going to get merged or any chance you could review this?

[anthonywebb]

I need this as well, hoping push notifications can be properly supported in react, seems kind of half baked and broken in its current state.

[DannyvanderJagt]

@PhilippKrone They are a little busy with the android release at the moment I think. But it would be nice if this could be merged/reviewed. @ide Let us/me know if we can help you.

@anthonywebb push notifications are working in React-Native for IOS when you apply the fix from this PR. I have written a tutorial about How to use push notifications in React-Native., it also includes the instructions to apply that fix to your project. Besides the push notifications, there are some issues and PRs for local notifications in IOS but nothing is merged yet (as far I know).

[justinmakaila]

This is great. I'd love for this to be integrated. Any estimates?

[JonnyBGod]

+1

[DannyvanderJagt]

@justinmakaila There is not estimate. The React-Native team is very busy at the moment. I will update and rebase this PR this weekend to get it up to date.

[jadsonlourenco]

+1

[satya164]

@DannyvanderJagt Any updates on this?

[basketofsoftkittens]

+1

[satya164]

Closing since no activity on the PR. let's re-open if you wanna work on it again.

[niftylettuce]

Can we get this in?

[niftylettuce]

If anyone else needs something temporary, add this to your AppDelegate.m file:

// listen for errors (since iOS simulator doesn't allow push notification)
// <https://github.com/facebook/react-native/pull/2336>
// <http://stackoverflow.com/a/31707874>
- (void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error
{
  RCTLogWarn(@"failed to register for notifications %@", error);
  //[RCTPushNotificationManager application:application didFailToRegisterForRemoteNotificationsWithError:error];
}

[DannyvanderJagt]

@niftylettuce Yes of course we can get this in. I will revisit this PR this weekend and hopefully it will get merged soon.

I'm sorry for the big delay but I just got slammed with work the last few months.

[DannyvanderJagt]

I couldn't get the old branch updated without destroying this PR. I forked the master of react-native today and added back and updated all the code of the this PR.

See: #7694

@niftylettuce Thank you for reminding me :)