ReactTextView extends AppCompatTextView #23321
Conversation
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@cpojer is there anything I can help with? |
facebook-github-bot
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
|
@dulmandakh merged commit ba0c3ff into |
Summary: Google recommends to use AppCompat widgets, and this PR changes ReactTextView to extend AppCompatTextView. [Android] [Changed] - ReactTextView extends AppCompatTextView Pull Request resolved: facebook#23321 Differential Revision: D13986149 Pulled By: cpojer fbshipit-source-id: 878849fff12dc5478bb0d0952b2c22695391e81a
Summary: Google recommends to use AppCompat widgets, and this PR changes ReactTextView to extend AppCompatTextView. [Android] [Changed] - ReactTextView extends AppCompatTextView Pull Request resolved: #23321 Differential Revision: D13986149 Pulled By: cpojer fbshipit-source-id: 878849fff12dc5478bb0d0952b2c22695391e81a
Summary
Google recommends to use AppCompat widgets, and this PR changes ReactTextView to extend AppCompatTextView.
Changelog
[Android] [Changed] - ReactTextView extends AppCompatTextView
Test Plan
CI is green, and everything works as normal.