Refine Keyboard API Event typings #23272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: - Improve type inference of the `event.easing` keyboard event property with the `KeyboardEventEasing` type. - Exporting `KeyboardEventName` and `KeyboardEventEasing` for others to use. - Removing unnecessary optional property flag (ie.`?`) for all properties in `KeyboardEvent`. (I personally haven't seen any of the properties not being returned for all keyboard events). [iOS] [Changed] - Refine Keyboard API Event typings Pull Request resolved: facebook#23272 Differential Revision: D13941758 Pulled By: cpojer fbshipit-source-id: 4891898c29cf6963069dbe6b4d439694761fd9e7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
event.easingkeyboard event property with theKeyboardEventEasingtype.KeyboardEventNameandKeyboardEventEasingfor others to use.?) for all properties inKeyboardEvent. (I personally haven't seen any of the properties not being returned for all keyboard events).Changelog
[iOS] [Changed] - Refine Keyboard API Event typings
Test Plan
KeyboardEventtype.