[Standalone for Native Component] Add types to RCTSnapshotNativeComponent #23111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Naturalclar
changed the title
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cpojer
approved these changes
Jan 23, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@Naturalclar merged commit 67ad72f into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Changelog: ---------- [iOS][Changed] - added types to RCTSnapshotNativeComponent.js, as mentioned in facebook#22990 Pull Request resolved: facebook#23111 Differential Revision: D13781429 Pulled By: cpojer fbshipit-source-id: 7efffe150fd29cbfbb3a6b8f13e38295f83acb3c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
[iOS][Changed] - added types to RCTSnapshotNativeComponent.js, as mentioned in #22990
Test Plan: