Added WebView deprecation warning #22980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Titozzz
force-pushed
the
added-webview-deprecation-warning
branch
from
aecc698
to
ff32980
Compare
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
react-native-bot
added
🔶Components
Component: WebView
grabbou
reviewed
Jan 14, 2019
| if (!showedWebWiewDeprecation) { | ||
| console.warn( | ||
| 'WebView has been extracted from react-native core and will be removed in a future release. ' + | ||
| 'See https://github.com/react-native-community/react-native-webview for more information', |
There was a problem hiding this comment.
Looks good!
I would consider adding a note about the new npm package, similar to what Navigator is doing:
grabbou
approved these changes
Jan 14, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
grabbou
pushed a commit
that referenced
this pull request
Jan 16, 2019
Summary: Changelog: ---------- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. [General] [Deprecated] - Deprecation warning for WebView as it has been extracted from core. Pull Request resolved: #22980 Differential Revision: D13664505 Pulled By: hramos fbshipit-source-id: 0cfc06015e77c52bed9eeebd97c8cbca6eacd8ce
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Changelog: ---------- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. [General] [Deprecated] - Deprecation warning for WebView as it has been extracted from core. Pull Request resolved: facebook#22980 Differential Revision: D13664505 Pulled By: hramos fbshipit-source-id: 0cfc06015e77c52bed9eeebd97c8cbca6eacd8ce
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Changelog: ---------- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. [General] [Deprecated] - Deprecation warning for WebView as it has been extracted from core. Pull Request resolved: facebook#22980 Differential Revision: D13664505 Pulled By: hramos fbshipit-source-id: 0cfc06015e77c52bed9eeebd97c8cbca6eacd8ce
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example.
[General] [Deprecated] - Deprecation warning for WebView as it has been extracted from core.
Test Plan:
importing WebView from react-native will now trigger a warning.