[Android] [Fixed] Fix the IllegalViewOperationException when updateLayout in NativeViewHierarchyManager

[raphael-liu]

[Android] [Fixed] Fix the IllegalViewOperationException when updateLayout in NativeViewHierarchyManager.

TestPlan

No plan.

ChangeLog

Remove the code of throwing IllegalViewOperationException, print the log and return instead.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[pull-bot]

	Warnings
⚠️	📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️	📋 Changelog - This PR appears to be missing Changelog.

Generated by 🚫 dangerJS

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[cpojer]

This doesn't really seem like a fix to me as you are just commenting out an exception that is thrown for probably a good reason. I'm gonna close this pull request proactively but I'm happy to reopen it if you update your code, summary or test plan to verify that this change is actually something we want to merge. Thank you.

[raphael-liu]

This doesn't really seem like a fix to me as you are just commenting out an exception that is thrown for probably a good reason. I'm gonna close this pull request proactively but I'm happy to reopen it if you update your code, summary or test plan to verify that this change is actually something we want to merge. Thank you.

But at least, the exception message used a wrong tag.

        ViewManager parentViewManager = mTagsToViewManagers.get(parentTag);
        ViewGroupManager parentViewGroupManager;
        if (parentViewManager instanceof ViewGroupManager) {
          parentViewGroupManager = (ViewGroupManager) parentViewManager;
        } else {
          throw new IllegalViewOperationException(
              "Trying to use view with tag " + tag + " as a parent, but its Manager doesn't extends ViewGroupManager");
        }

The tag of the exception message should be the parentTag.