Feature: dev menu option to change packager location during runtime #21970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Tech: Bundler 📦
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
|
@chubakueno merged commit fd96e2c into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
…acebook#21970) Summary: Add an option to dev menu to change packager location on the fly on iOS (similar to Dev Settings in Android) Pull Request resolved: facebook#21970 Differential Revision: D14162776 Pulled By: cpojer fbshipit-source-id: 3cca4f4fbd8c599bd5342ba1ae64905a03270d48
hramos
removed
Import Started
|
It looks like this PR doesn't work with changing bundler ports. Created an issue here: #25772 |
aleclarson
pushed a commit
to alloc/react-native-macos
that referenced
this pull request
Nov 30, 2019
…#21970) Summary: Add an option to dev menu to change packager location on the fly on iOS (similar to Dev Settings in Android) Pull Request resolved: facebook/react-native#21970 Differential Revision: D14162776 Pulled By: cpojer fbshipit-source-id: 3cca4f4fbd8c599bd5342ba1ae64905a03270d48
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to dev menu to change packager location on the fly on iOS (similar to Dev Settings in Android)
Test Plan:
Tested the code change in iOS 12.1 beta 5, Xcode 10.1 beta. Set up two different PCs in the same LAN, then pointed to each one of them during runtime. Then closed the app and reopened to confirm that the last setting persists in user defaults.
Release Notes:
[IOS] [FEATURE] [DevMenu] - Added an option to change packager location during runtime