Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump fbjs-scripts to ^1.0.0 #21880

Closed
wants to merge 1 commit into from
Closed

Bump fbjs-scripts to ^1.0.0 #21880

wants to merge 1 commit into from

Conversation

jmheik
Copy link
Contributor

@jmheik jmheik commented Oct 21, 2018

This PR bumps also fbjs-scripts to latest version. Benefit is smaller node_modules and less deps to download as newer version doesn't depend on babel6 anymore.

Test Plan:

All the test should be passing. As far as I see, only fbjs-scripts/jest/createCacheKeyFunction is used, and its implementation has not changed in a year.

Release Notes:

[GENERAL] [ENHANCEMENT] - Bump fbjs-scripts dependency to ^1.0.0

@jmheik jmheik requested a review from hramos as a code owner October 21, 2018 10:43
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2018
@pull-bot
Copy link

Warnings
⚠️

🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS

@kelset
Copy link
Contributor

kelset commented Oct 26, 2018

Closing since this commit already accomplish this ee03459

@kelset kelset closed this Oct 26, 2018
@jmheik
Copy link
Contributor Author

jmheik commented Oct 26, 2018

@kelset Commit you linked updates fbjs, not fbjs-scripts. My motivation for this PR was to update fbjs-scripts as the old version transitively pulls lots of babel6 deps that are not needed.

@radeno
Copy link
Contributor

radeno commented Oct 26, 2018 •
edited
Loading

@kelset, @jmheik is right, fbjs-scripts 0.8 still depends on babel 6. need to update to version 1.0

@kelset
Copy link
Contributor

kelset commented Oct 26, 2018 •
edited
Loading

oh sorry, you are correct - I'll reopen (I thought that basically they were "connected", since these should be helpers to use the main fbjs, but yeah seems like we would have to update that dept too).

That said I'm not sure when this will be merged, since it touches the yarn.lock

@kelset kelset reopened this Oct 26, 2018
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Oct 29, 2018
facebook-github-bot
facebook-github-bot approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos
Copy link
Contributor

hramos commented Oct 29, 2018

Thanks for the PR. Lorenzo is correct, this will require some work on our end to land since it touches package.json, and I can take care of it.

@facebook-github-bot

This comment has been minimized.

Sign in to view
@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Oct 30, 2018
@react-native-bot
Copy link
Collaborator

@jmheik merged commit cdbf719 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 30, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 30, 2018
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@jmheik @facebook-github-bot
Bump fbjs-scripts to ^1.0.0 (facebook#21880)
766a663 
Summary:
This PR bumps also fbjs-scripts to latest version. Benefit is smaller node_modules and less deps to download as newer version doesn't depend on babel6 anymore.
Pull Request resolved: facebook#21880

Differential Revision: D12832002

Pulled By: hramos

fbshipit-source-id: fa801aeb70a2f22be6f9c05cd6d981d0af0a0da9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jmheik @pull-bot @kelset @radeno @hramos @facebook-github-bot @react-native-bot