Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[createReactClass] Remove createReactClass from SwipeableRow #21876

Closed
wants to merge 2 commits into from
Closed

[createReactClass] Remove createReactClass from SwipeableRow #21876

wants to merge 2 commits into from

Conversation

exced
Copy link
Contributor

@exced exced commented Oct 21, 2018

Related to #21581

Remove createReactClass from SwipeableRow.

Test Plan:

  • All flow tests succeed.
    -RNTester > SwipeableFlatList, scroll, swipe left, swipe right
    -RNTester > SwipeableListView, scroll, swipe left, swipe right

Release Notes:

[GENERAL] [ENHANCEMENT] [SwipeableRow.js] - rm createReactClass

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2018
@RSNara RSNara changed the title Remove createReactClass from SwipeableRow [createReactClass] Remove createReactClass from SwipeableRow Oct 22, 2018
@andrew-pyle andrew-pyle mentioned this pull request Oct 26, 2018
Closed
15 tasks
RSNara
RSNara approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 LGTM

facebook-github-bot
facebook-github-bot reviewed Oct 29, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@exced merged commit 14e1628 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Nov 2, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 2, 2018
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@exced @facebook-github-bot
Remove createReactClass from SwipeableRow (facebook#21876)
20147bb 
Summary:
Related to facebook#21581

Remove createReactClass from SwipeableRow.

- All flow tests succeed.
-RNTester > SwipeableFlatList, scroll, swipe left, swipe right
-RNTester > SwipeableListView, scroll, swipe left, swipe right

[GENERAL] [ENHANCEMENT] [SwipeableRow.js] - rm createReactClass
Pull Request resolved: facebook#21876

Reviewed By: TheSavior

Differential Revision: D12828034

Pulled By: RSNara

fbshipit-source-id: df02ed14e72bf6b0ad3cff33076a6f40870266a8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@RSNara RSNara RSNara approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@exced @react-native-bot @RSNara @facebook-github-bot