Copy bundled resources and js in Android App Bundle builds #21738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android App Bundle builds use the packageBundle and bundle tasks instead of the package and assemble tasks the APK builds use. Because of this, the resources and js bundles weren't getting copied into the final artifact. In an App Bundle build, the merged assets must be present during the buildPreBundle step in order to arrive in the App Bundle.
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Platform: Android
|
This looks great! cc @cpojer @janicduplessis @dulmandakh What do you think? |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Looks good to me. Thanks for submitting a PR to React Native. |
grabbou
pushed a commit
that referenced
this pull request
Jan 16, 2019
Summary: Android App Bundle builds use the packageBundle and bundle tasks instead of the package and assemble tasks the APK builds use. Because of this, the resources and js bundles weren't getting copied into the final artifact. In an App Bundle build, the merged assets must be present during the buildPreBundle step in order to arrive in the App Bundle. Pull Request resolved: #21738 Differential Revision: D13669288 Pulled By: cpojer fbshipit-source-id: 0e985983f04504b69e447dbc1f3f34cf8f4eb927
evgeni-wix
pushed a commit
to wix-playground/react-native
that referenced
this pull request
Feb 4, 2019
…21738) Summary: Android App Bundle builds use the packageBundle and bundle tasks instead of the package and assemble tasks the APK builds use. Because of this, the resources and js bundles weren't getting copied into the final artifact. In an App Bundle build, the merged assets must be present during the buildPreBundle step in order to arrive in the App Bundle. Pull Request resolved: facebook#21738 Differential Revision: D13669288 Pulled By: cpojer fbshipit-source-id: 0e985983f04504b69e447dbc1f3f34cf8f4eb927
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
…21738) Summary: Android App Bundle builds use the packageBundle and bundle tasks instead of the package and assemble tasks the APK builds use. Because of this, the resources and js bundles weren't getting copied into the final artifact. In an App Bundle build, the merged assets must be present during the buildPreBundle step in order to arrive in the App Bundle. Pull Request resolved: facebook#21738 Differential Revision: D13669288 Pulled By: cpojer fbshipit-source-id: 0e985983f04504b69e447dbc1f3f34cf8f4eb927
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…21738) Summary: Android App Bundle builds use the packageBundle and bundle tasks instead of the package and assemble tasks the APK builds use. Because of this, the resources and js bundles weren't getting copied into the final artifact. In an App Bundle build, the merged assets must be present during the buildPreBundle step in order to arrive in the App Bundle. Pull Request resolved: facebook#21738 Differential Revision: D13669288 Pulled By: cpojer fbshipit-source-id: 0e985983f04504b69e447dbc1f3f34cf8f4eb927
KusStar
pushed a commit
to KusStar/react-native
that referenced
this pull request
Nov 11, 2020
…21738) Summary: Android App Bundle builds use the packageBundle and bundle tasks instead of the package and assemble tasks the APK builds use. Because of this, the resources and js bundles weren't getting copied into the final artifact. In an App Bundle build, the merged assets must be present during the buildPreBundle step in order to arrive in the App Bundle. Pull Request resolved: facebook#21738 Differential Revision: D13669288 Pulled By: cpojer fbshipit-source-id: 0e985983f04504b69e447dbc1f3f34cf8f4eb927
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android App Bundle builds use the packageBundle and bundle tasks instead
of the package and assemble tasks the APK builds use. Because of this,
the resources and js bundles weren't getting copied into the final
artifact. In an App Bundle build, the merged assets must be present
during the buildPreBundle step in order to arrive in the App Bundle.
Test Plan:
(Clean project between each build, as leftovers from past builds would previously cause the bundle build to incidentally work.)
Release Notes:
[ANDROID] [BUGFIX] [react.gradle] - Fix packaging resources and js in Android App Bundle builds