[createReactClass] remove createReactClass from the IntegrationTests/ReactContentSizeUpdateTest.js #21622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Oct 10, 2018
|
|
||
| UNSAFE_componentWillMount: function() { |
RSNara
approved these changes
Oct 10, 2018
|
|
||
| rootViewDidChangeIntrinsicSize: function(intrinsicSize) { | ||
| updateViewSize = () => { |
There was a problem hiding this comment.
The only call-site for this method is in componentDidMount:
componentDidMount() {
this._timeoutID = setTimeout(() => {
this.updateViewSize();
}, 1000);
},Given the way it's called, we don't need to bind this function.
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@nd-02110114 merged commit 96bdfe3 into |
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…ateTest.js (facebook#21622) Summary: Related to facebook#21581 . Removed createReactClass from the IntegrationTests/ReactContentSizeUpdateTest.js - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ENHANCEMENT] [IntegrationTests/ReactContentSizeUpdateTest.js] - remove createReactClass dependency Pull Request resolved: facebook#21622 Reviewed By: TheSavior Differential Revision: D10302181 Pulled By: RSNara fbshipit-source-id: 97b955070deb7a244f335ad609f26ffc07578c01
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21581 .
Removed createReactClass from the IntegrationTests/ReactContentSizeUpdateTest.js
Test Plan
Release Notes
[GENERAL] [ENHANCEMENT] [IntegrationTests/ReactContentSizeUpdateTest.js] - remove createReactClass dependency