[createReactClass] remove createReactClass from RNTester/js/ProgressViewIOSExample.js #21611
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| progress: 0, | ||
| }; | ||
| }, | ||
| class ProgressViewExample extends React.Component<{}, State> { |
There was a problem hiding this comment.
We should make the props exact.
type Props = {||};
class ProgressViewExample extends React.Component<Props, State> {
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@himanshusoni merged commit a7f9583 into |
…21611) Summary: Related to #21581 . Removed createReactClass from the RNTester/js/ProgressViewIOSExample.js Test Plan ---------- - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android - [x] Run RNTester app, go to ProgressViewIOS component, everything works. Release Notes -------------- [GENERAL] [ENHANCEMENT] [RNTester/js/ProgressViewIOSExample.js] - remove createReactClass dependency Pull Request resolved: facebook/react-native#21611 Reviewed By: TheSavior Differential Revision: D10304566 Pulled By: RSNara fbshipit-source-id: 98a9dc83a0517a2866c4174ae254e1a9d9785b87
…acebook#21611) Summary: Related to facebook#21581 . Removed createReactClass from the RNTester/js/ProgressViewIOSExample.js Test Plan ---------- - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android - [x] Run RNTester app, go to ProgressViewIOS component, everything works. Release Notes -------------- [GENERAL] [ENHANCEMENT] [RNTester/js/ProgressViewIOSExample.js] - remove createReactClass dependency Pull Request resolved: facebook#21611 Reviewed By: TheSavior Differential Revision: D10304566 Pulled By: RSNara fbshipit-source-id: 98a9dc83a0517a2866c4174ae254e1a9d9785b87
Related to #21581 .
Removed createReactClass from the RNTester/js/ProgressViewIOSExample.js
Test Plan
Release Notes
[GENERAL] [ENHANCEMENT] [RNTester/js/ProgressViewIOSExample.js] - remove createReactClass dependency