Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[createReactClass] remove createReactClass from the RNTester/js/TextExample.ios.js #21603

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented Oct 9, 2018

Related to #21581 .
Removed createReactClass from the RNTester/js/TextExample.ios.js

Test Plan

  • npm run prettier
  • npm run flow-check-ios
  • npm run flow-check-android

Release Notes

[GENERAL] [ENHANCEMENT] [RNTester/js/TextExample.ios.js] - remove createReactClass dependency

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2018
@nissy-dev nissy-dev changed the title remove createreactClass remove createreactClass from the RNTester/js/TextExample.ios.js Oct 9, 2018
@nissy-dev nissy-dev changed the title remove createreactClass from the RNTester/js/TextExample.ios.js remove createReactClass from the RNTester/js/TextExample.ios.js Oct 9, 2018
@RSNara RSNara changed the title remove createReactClass from the RNTester/js/TextExample.ios.js [createReactClass] remove createReactClass from the RNTester/js/TextExample.ios.js Oct 9, 2018
Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 😁

var {Text, TextInput, View, LayoutAnimation, Button} = ReactNative;
const React = require('react');
const ReactNative = require('react-native');
const {Text, TextInput, View, LayoutAnimation, Button} = ReactNative;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

|};

class AdjustingFontSize extends React.Component<{}, AdjustingFontSizeState> {
static displayName: ?string = 'AdjustingFontSize';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, no need for this.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Oct 9, 2018
@react-native-bot
Copy link
Collaborator

@nd-02110114 merged commit 5512c47 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 9, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 9, 2018
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Apr 14, 2019
Summary:
Related to #21581 .
Removed createReactClass from the RNTester/js/TextExample.ios.js

- [x] npm run prettier
- [x]  npm run flow-check-ios
- [x] npm run flow-check-android

[GENERAL] [ENHANCEMENT] [RNTester/js/TextExample.ios.js] - remove createReactClass dependency
Pull Request resolved: facebook/react-native#21603

Differential Revision: D10260872

Pulled By: RSNara

fbshipit-source-id: f63476756a10ddbce04da901012247d028579d53
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
…book#21603)

Summary:
Related to facebook#21581 .
Removed createReactClass from the RNTester/js/TextExample.ios.js

- [x] npm run prettier
- [x]  npm run flow-check-ios
- [x] npm run flow-check-android

[GENERAL] [ENHANCEMENT] [RNTester/js/TextExample.ios.js] - remove createReactClass dependency
Pull Request resolved: facebook#21603

Differential Revision: D10260872

Pulled By: RSNara

fbshipit-source-id: f63476756a10ddbce04da901012247d028579d53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants