[TimerMixin] Removing TimerMixin on ProgressViewIOSExample #21500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
changed the title
|
@gvarandas merged commit f1d6e22 into |
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Apr 14, 2019
Summary: Related to #21485. Removed TimerMixin from the `RNTester/js/ProgressViewIOSExample.js` screen since it is currently not used. - [x] `npm run prettier` - [x] `npm run flow-check-ios` - [x] `npm run flow-check-android` - [x] runtime tests using `ProgressViewIOSExample` on Android and iOS **RNTester steps** - [x] Run RNTester. - [x] Navigate to `ProgressViewIOSExample` and check if the animations are executed correctly and without lag. [GENERAL] [ENHANCEMENT] [RNTester/js/ProgressViewIOSExample.js] - remove TimerMixin dependency Pull Request resolved: facebook/react-native#21500 Reviewed By: TheSavior Differential Revision: D10218366 Pulled By: RSNara fbshipit-source-id: b44a0bbb50f6b0e85f406904131804eace941335
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Related to facebook#21485. Removed TimerMixin from the `RNTester/js/ProgressViewIOSExample.js` screen since it is currently not used. - [x] `npm run prettier` - [x] `npm run flow-check-ios` - [x] `npm run flow-check-android` - [x] runtime tests using `ProgressViewIOSExample` on Android and iOS **RNTester steps** - [x] Run RNTester. - [x] Navigate to `ProgressViewIOSExample` and check if the animations are executed correctly and without lag. [GENERAL] [ENHANCEMENT] [RNTester/js/ProgressViewIOSExample.js] - remove TimerMixin dependency Pull Request resolved: facebook#21500 Reviewed By: TheSavior Differential Revision: D10218366 Pulled By: RSNara fbshipit-source-id: b44a0bbb50f6b0e85f406904131804eace941335
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21485.
Removed TimerMixin from the
RNTester/js/ProgressViewIOSExample.jsscreen since it is currently not used.Test Plan
npm run prettiernpm run flow-check-iosnpm run flow-check-androidProgressViewIOSExampleon Android and iOSRNTester steps
ProgressViewIOSExampleand check if the animations are executed correctly and without lag.Release Notes
[GENERAL] [ENHANCEMENT] [RNTester/js/ProgressViewIOSExample.js] - remove TimerMixin dependency