-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug only code were leaking into release builds on iOS. #21232
Debug only code were leaking into release builds on iOS. #21232
Conversation
…ways defined, it is just rather 0 or 1.
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@dryganets merged commit d1ff0b0 into Once this commit is added to a release, you will see the corresponding version tag below the description at d1ff0b0. If the commit has a single |
Summary: RCT_DEBUG is always defined - it is just rather 0 or 1 so ```#ifndef RCT_DEBUG is always true``` Pull Request resolved: #21232 Differential Revision: D9982316 Pulled By: hramos fbshipit-source-id: 5408bfcf95a6ed2beae38217a6ad1ee43950857d
) Summary: RCT_DEBUG is always defined - it is just rather 0 or 1 so ```#ifndef RCT_DEBUG is always true``` Pull Request resolved: facebook#21232 Differential Revision: D9982316 Pulled By: hramos fbshipit-source-id: 5408bfcf95a6ed2beae38217a6ad1ee43950857d
RCT_DEBUG is always defined - it is just rather 0 or 1 so
#ifndef RCT_DEBUG is always true
Test Plan:
No testing is needed it is minor typo fix.
Release Notes:
[MINOR] [IOS] [DEBUG] - Message