local-cli: remove 'unbundle' naming in CLI #21013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@jeanlauliac merged commit e855152 into Once this commit is added to a release, you will see the corresponding version tag below the description at e855152. If the commit has a single |
gengjiawen
pushed a commit
to gengjiawen/react-native
that referenced
this pull request
Sep 14, 2018
Summary: This also relink the require() onto `RamBundle.js` from Metro so we can remove `unbundle.js` from there completely. Pull Request resolved: facebook#21013 Reviewed By: hramos Differential Revision: D9721443 Pulled By: jeanlauliac fbshipit-source-id: 3e42ebde4cb2c735ef0934ba3b1e20f1054440df
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: This also relink the require() onto `RamBundle.js` from Metro so we can remove `unbundle.js` from there completely. Pull Request resolved: facebook/react-native#21013 Reviewed By: hramos Differential Revision: D9721443 Pulled By: jeanlauliac fbshipit-source-id: 3e42ebde4cb2c735ef0934ba3b1e20f1054440df
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This also relink the require() onto `RamBundle.js` from Metro so we can remove `unbundle.js` from there completely. Pull Request resolved: facebook#21013 Reviewed By: hramos Differential Revision: D9721443 Pulled By: jeanlauliac fbshipit-source-id: 3e42ebde4cb2c735ef0934ba3b1e20f1054440df
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also relink the require() onto
RamBundle.jsfrom Metro so we can removeunbundle.jsfrom there completely.Test Plan:
No logic change, relying on automated tests. Not breaking because it removes a CLI option, however that option would
throwsystematically.Release Notes:
[CLI] [MINOR] [local-cli] - Remove deprecated
unbundleCLI command