Update link command for Android project #20853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #20767 bumped the version of the Android Gradle Plugin to v3 which uses the newer Gradle dependency configurations `implementation` and `api` which make `compile` obsolete. While the PR updated the template Gradle configuration, it did not cover the `link` command which will still link native modules using `compile` which will result in a warning message during app build. Since `compile` will be eventually removed by Gradle, this commit updates the `link` command to attach native modules using `implementation`.
facebook-github-bot
added
the
CLA Signed
dulmandakh
approved these changes
Sep 8, 2018
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 8, 2018
There was a problem hiding this comment.
dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@matt-block merged commit 4dfdec9 into Once this commit is added to a release, you will see the corresponding version tag below the description at 4dfdec9. If the commit has a single |
gengjiawen
pushed a commit
to gengjiawen/react-native
that referenced
this pull request
Sep 14, 2018
Summary: Motivation: -------------- PR facebook#20767 bumped the version of the Android Gradle Plugin to v3 which uses the newer Gradle dependency configurations `implementation` and `api` which make `compile` obsolete. While the PR updated the template Gradle configuration, it did not cover the `link` command which will still link native modules using `compile` resulting in a warning message beeing displayed during an app build. Since `compile` will be eventually removed by Gradle, this commit updates the `link` command to attach native modules using `implementation`. Pull Request resolved: facebook#20853 Differential Revision: D9733888 Pulled By: hramos fbshipit-source-id: 22853480d7ba7be65e3387effda2fd6c72b6906a
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Motivation: -------------- PR #20767 bumped the version of the Android Gradle Plugin to v3 which uses the newer Gradle dependency configurations `implementation` and `api` which make `compile` obsolete. While the PR updated the template Gradle configuration, it did not cover the `link` command which will still link native modules using `compile` resulting in a warning message beeing displayed during an app build. Since `compile` will be eventually removed by Gradle, this commit updates the `link` command to attach native modules using `implementation`. Pull Request resolved: facebook/react-native#20853 Differential Revision: D9733888 Pulled By: hramos fbshipit-source-id: 22853480d7ba7be65e3387effda2fd6c72b6906a
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Motivation: -------------- PR facebook#20767 bumped the version of the Android Gradle Plugin to v3 which uses the newer Gradle dependency configurations `implementation` and `api` which make `compile` obsolete. While the PR updated the template Gradle configuration, it did not cover the `link` command which will still link native modules using `compile` resulting in a warning message beeing displayed during an app build. Since `compile` will be eventually removed by Gradle, this commit updates the `link` command to attach native modules using `implementation`. Pull Request resolved: facebook#20853 Differential Revision: D9733888 Pulled By: hramos fbshipit-source-id: 22853480d7ba7be65e3387effda2fd6c72b6906a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
PR #20767 bumped the version of the Android Gradle Plugin to v3 which uses the newer Gradle dependency configurations
implementationandapiwhich makecompileobsolete.While the PR updated the template Gradle configuration, it did not cover the
linkcommand which will still link native modules usingcompileresulting in a warning message beeing displayed during an app build.Since
compilewill be eventually removed by Gradle, this commit updates thelinkcommand to attach native modules usingimplementation.Test Plan:
Ran the tests on my branch:
Note: test_android, test_detox_end_to_end and test_objc seem to fail for other reasons discussed in #20854.
then,
implementationdependency configuration keywordlocal-cli/linkfolder from my branch intodemoProject/node_modules/react-native/local-cliandroid/app/build.gradlehas been patched correctly withimplementation.android/settings.gradleandMainApplication.javahave been patched as usual.Related PRs:
Release Notes:
[CLI] [ENHANCEMENT] [local-cli/link] - Updated
linkto link Android modules asimplementationdependencies.