Whitelist react-native-dom in haste/cli config defaults #20393
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
react-native-dom
tohasteImpl.js
because it's not currently possible to configure it from an out of tree platform. Also adds the relevantprovidesModuleNodeModules
andplatforms
values to the default RN CLI config. This should hopefully be able to be removed once better support for out of tree platforms is implemented.Test Plan:
Confirmed that the updated config correctly builds an RNDom project by pulling my fork as a dependency (though it required some other changes for some unrelated
local-cli
issues).Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[CLI] [ENHANCEMENT] [jest/hasteImpl.js] - Whitelist react-native-dom in haste/cli config defaults