Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have circle ci use xcode 9.4 #19629

Closed
wants to merge 4 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ android_defaults: &android_defaults
macos_defaults: &macos_defaults
<<: *defaults
macos:
xcode: "9.2.0"
xcode: "9.4.0"

version: 2
jobs:
Expand Down Expand Up @@ -374,9 +374,8 @@ jobs:
- attach_workspace:
at: ~/react-native

- run: xcrun instruments -w "iPhone 5s (11.2)" || true
- run: xcrun instruments -w "iPhone 5s (11.4)" || true
# See https://github.com/Homebrew/homebrew-core/issues/26358.
- run: brew upgrade python > /dev/null
- run: brew install watchman
- run: *run-objc-ios-tests

Expand All @@ -390,9 +389,8 @@ jobs:
- attach_workspace:
at: ~/react-native

- run: xcrun instruments -w "Apple TV 1080p (11.2)" || true
- run: xcrun instruments -w "Apple TV (11.4)" || true
# See https://github.com/Homebrew/homebrew-core/issues/26358.
- run: brew upgrade python > /dev/null
- run: brew install watchman
- run: *run-objc-tvos-tests

Expand All @@ -406,7 +404,7 @@ jobs:
- attach_workspace:
at: ~/react-native

- run: xcrun instruments -w "iPhone 5s (11.2)" || true
- run: xcrun instruments -w "iPhone 5s (11.4)" || true
- run: *run-objc-ios-e2e-tests

- store_test_results:
Expand Down