-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump 0.49 to React 16 #19274
Bump 0.49 to React 16 #19274
Conversation
Reviewed By: gaearon Differential Revision: D5950896 fbshipit-source-id: 74aebcee8a64e8552b170223adf59ed4ed905a74
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Looks like the CI is failing for totally unrelated reasons:
|
We will need to make CI pass in order to ship-it anyway. I removed the change of the React Native version as this is automated and also creates a git tag on Github. Going to merge it now and see what CI tells us. |
This reverts commit 312d37f.
This reverts commit 312d37f.
This reverts commit 312d37f.
Cherrypicks the update to React 16.0.0 from RN 0.50 into 0.49, so that 0.49 can be used with a non-rc/beta version of React. Bumps RN 0.49 to 0.49.6. Fixes react-native-community/releases#18
We explored also cherrypicking the updates to prettier v1.7 and flow v0.56.0, however determined the related commits involved more changes than we'd like to back port.
Discussed with @hramos and @grabbou on contributor slack.
Test Plan
Cherrypicked 678a7f3. Local run of tests, lint, and flow were successful.
Related PRs
None
Release Notes
[GENERAL] [MINOR] [-------------] - Updated React to v16.0.0