Make generic event types less platform-specific #18378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous PR (#18308) enabled lazy loading of view manager constants. This PR enables any platform to use of generic bubbling and direct event types by exposing the constants `genericBubblingEventTypes` or `genericDirectEventTypes` on the UIManagerModule.
|
cc @matthargett |
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR (#18308) enabled lazy loading of view manager constants.
This PR enables any platform to use of generic bubbling and direct event types by exposing the constants
genericBubblingEventTypesorgenericDirectEventTypeson the UIManagerModule.Motivation
I am adding lazy view managers to react-native-windows, and would like to use the same approach of loading "generic" event types that apply to all view managers only once.
Test Plan
Run jest tests. Run sample app on iOS and Android.
Related PRs
#18308
Release Notes
[GENERAL][ENHANCEMENT][MINOR][Libraries/ReactNative/requireNativeComponent.js] - Enable any platform to use generic event types.