-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[io.js] Print a warning message if the user is not on io.js 2.x #1824
Conversation
@ide I just tried
But it gives following error for me
I think we should mention
also. |
@prathamesh-sonpatki good catch. the instructions now include |
awesome. |
dda3d28
to
791ffcf
Compare
Detects if the user is on Node or io.js 1.x and prints a banner explaining how to upgrade. We probably should link to more detailed upgrade docs so this is just a start.
Removed the bit about "next release" from the message since the jest upgrade and io.js support already landed. Moving fast! |
@nicklockwood could you help merge this in before we cut 0.8.0-rc? This is the last commit I'd like to include in the RC and the rest of the items on #1864's checklist can wait for 0.8.0-rc.2. |
@ide, I don't understand the JS side of the platform well enough to judge the implications of this. Maybe @vjeux or @tadeuzagallo can weigh in? |
LGTM @facebook-github-bot import |
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/120269048309122/int_phab to review. |
Thanks guys! Ready to release 0.8.0-rc very soon! |
Summary: Detects if the user is on Node or io.js 1.x and prints a banner explaining how to upgrade. We probably should link to more detailed upgrade docs so this is just a start. I also added a function to format banners that is kind of useful. Addresses part of #1737 ![packager-banner](https://cloud.githubusercontent.com/assets/379606/8447050/ad615402-1f67-11e5-8c02-ece5f7488135.png) Closes facebook/react-native#1824 Github Author: James Ide <[email protected]>
Detects if the user is on Node or io.js 1.x and prints a banner explaining how to upgrade. We probably should link to more detailed upgrade docs so this is just a start.
I also added a function to format banners that is kind of useful.
Addresses part of #1737