Update React.podspec for RCTText #17655
Conversation
Some of the classes of RCTText are now in the subfolders, this will fix pod integration for texts
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
added
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
cc @alloy |
|
Thanks! |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@ide is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Some of the classes of RCTText are now in the subfolders, this will fix pod integration for texts <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> I have integrated React Native into my project with [this guide](https://facebook.github.io/react-native/docs/integration-with-existing-apps.html) and got the error `No component found for view with name RCTText`. Searching in the web did not give any useful information so I started to dig into the code and found out that there is now subfolders and pod taking only root classes. After making this change project started to compile again. Create empty project with pods integrated add `RCTText` subspec and in `.js` file add some `<Text>` element Fixed `RCTText` subspec integration. Closes #17655 Differential Revision: D6751039 Pulled By: hramos fbshipit-source-id: f4538d1125af2b45f36e2fa535382e032dbc8f4e
Some of the classes of RCTText are now in the subfolders, this will fix pod integration for texts
Motivation
I have integrated React Native into my project with this guide and got the error
No component found for view with name RCTText. Searching in the web did not give any useful information so I started to dig into the code and found out that there is now subfolders and pod taking only root classes. After making this change project started to compile again.Test Plan
Create empty project with pods integrated add
RCTTextsubspec and in.jsfile add some<Text>elementRelease Notes
Fixed
RCTTextsubspec integration.