Fix #1689 - props mutated in TextInput render method. #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| var props = { | ||
| ...this.props, | ||
| style: [styles.input, this.props.style] | ||
| }; |
There was a problem hiding this comment.
can you update this to use spaces instead of tabs?
also put a trailing comma after the last property
There was a problem hiding this comment.
No problem - sorry, been away for a few days, will look at doing this shortly.
|
Fixed a flow warning and updated the PR to use spaces instead of tabs. |
|
Sorry, my bad, got some issues with Flow - having trouble validating against: 'Text.propTypes.style' on line 286 and not hugely up on spread syntax yet. #66b6e61 breaks Flow. |
|
@admmasters try |
|
Again - a mad week - I was going to suggest whether or not you wanted me to use Object.assign to close this off :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1689 - mutating props within the render method.