Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow] Fix failure due to missing Metro flow types #17187

Closed
wants to merge 5 commits into from
Closed

[Flow] Fix failure due to missing Metro flow types #17187

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02f35ea
Fix Flow failure due to unexported Metro flow types
hramos Dec 13, 2017
170599e
Create OSS-specific directory for flow
hramos Dec 13, 2017
1f4c830
Add missing file
hramos Dec 14, 2017
38aa018
Update flowconfig used by the default local-cli template
hramos Dec 14, 2017
259068b
Ignore metro in cli template
hramos Dec 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .flowconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
; Ignore polyfills
.*/Libraries/polyfills/.*

; Ignore metro
.*/node_modules/metro/.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably want to update this as well: https://github.com/facebook/react-native/blob/master/local-cli/templates/HelloWorld/_flowconfig

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that template is due to be removed anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the PR that will move the template out: #16579

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this is a separate template (HelloNavigation). Taking a look.


[include]

[libs]
Expand Down
18 changes: 18 additions & 0 deletions flow/metro.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will get pulled in internally because react-native-github/flow is a lib dir for our xplat .flowconfig at facebook, right? Will this cause a problem?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to put this in like, an "oss-flow" folder @hramos.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, this folder is used in the xplat .flowconfig.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to flow-github, to follow the convention established by the react-native-github folder in xplat.

* Copyright (c) 2017-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
* @flow
*/

declare module 'metro' {
declare module.exports: any;
}

declare module 'metro/src/lib/TerminalReporter' {
declare module.exports: any;
}