Fixing bad link to RN documentation. #17048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot shipit |
|
Thank you for catching this! Prior to today, that link would have worked. I'll see if I can fix this in the updated website. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 1, 2017
There was a problem hiding this comment.
@chirag04 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@hramos great :) Thanks for getting back to me |
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: The link referencing the root of RN documentation was leading to a 404 error. As the docs don't seem to have a true "index" page, it makes sense that it goes to the top level entry in the docs, the "Getting Started Section". The alternative solution may be not linking that phrase at all, this seems helpful though. No changes in this pull request require any sort of unit/AB testing, the link directing to the correct place should be apparent. [DOCS] [BUGFIX] [README.md] - Fixing doc resource link. Closes facebook#17048 Differential Revision: D6464455 Pulled By: hramos fbshipit-source-id: 710dc882672d762478910538341b57cb1bb129bb
bowerman0
pushed a commit
to bowerman0/react-native
that referenced
this pull request
Dec 5, 2017
Summary: The link referencing the root of RN documentation was leading to a 404 error. As the docs don't seem to have a true "index" page, it makes sense that it goes to the top level entry in the docs, the "Getting Started Section". The alternative solution may be not linking that phrase at all, this seems helpful though. No changes in this pull request require any sort of unit/AB testing, the link directing to the correct place should be apparent. [DOCS] [BUGFIX] [README.md] - Fixing doc resource link. Closes facebook#17048 Differential Revision: D6464455 Pulled By: hramos fbshipit-source-id: 710dc882672d762478910538341b57cb1bb129bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The link referencing the root of RN documentation was leading to a 404 error. As the docs don't seem to have a true "index" page, it makes sense that it goes to the top level entry in the docs, the "Getting Started Section". The alternative solution may be not linking that phrase at all, this seems helpful though.
Test Plan
No changes in this pull request require any sort of unit/AB testing, the link directing to the correct place should be apparent.
Release Notes
[DOCS] [BUGFIX] [README.md] - Fixing doc resource link.