Return the appropriate status code from XHR #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also replace the error response with the actual |
|
In case of an error, would the client even receive a status code? I was under the impression that an error object is only passed in the case of a network navigation error. In my experiments, 4xx and 5xx server errors were still passed to the JS side with my changes. |
|
Oops, sorry about that, totally makes sense, the connection was ok, the response just wasn't 200. |
tadeuzagallo
added a commit
that referenced
this pull request
Mar 19, 2015
Return the appropriate status code from XHR
|
@tadeuzagallo: unfortunately you can't merge code like this. You need to use the internal tool to submit an internal diff. Otherwise this is going to be erased next time we sync |
vjeux
pushed a commit
to vjeux/react-native
that referenced
this pull request
Apr 13, 2015
Summary: Manually import pull request facebook#169 from github https://github.com/facebook/react-native/pull/169/files Test Plan: Just do a XMLHttpRequest
harrykiselev
pushed a commit
to harrykiselev/react-native
that referenced
this pull request
Aug 5, 2015
- Fix formatting of numbered list (replaces facebook#169) - Remove unused "development process" section
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
* Include a native module preparation guide with code scaffolding tool so that readers can jump straight into the code * Update native-modules-setup.md
react-one
pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries use the HTTP status code to interact with APIs. Rather than hardcoding the response code to 200, this sets the server-reported status code as the
statusproperty of an XHR instance.