Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pods] Preserve the local-cli directory #1674

Closed
wants to merge 1 commit into from

Conversation

paramaggarwal
Copy link
Contributor

In continuation of the discussion here in #363, the global react-native-cli refers to the local-cli directory when run inside the project. But when installed via Pods, this folder is deleted as it is not listed in the preserve_paths config in the pod spec.

@paramaggarwal paramaggarwal changed the title Preserve the local-cli directory via Pods [Pods] Preserve the local-cli directory Jun 18, 2015
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2015
@clayallsopp
Copy link
Contributor

👍 this would be very helpful

@paramaggarwal paramaggarwal force-pushed the patch-1 branch 2 times, most recently from 5651ec1 to 0d48bc9 Compare July 27, 2015 05:06
@paramaggarwal
Copy link
Contributor Author

Apologies, this change by itself does not make the react-native bundle command work as it assumes it to be inside the node_modules folder always. Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants