Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add tintColor to ActionSheetIOS documentation #16679

Closed
wants to merge 2 commits into from
Closed

[DOCS] Add tintColor to ActionSheetIOS documentation #16679

wants to merge 2 commits into from

Conversation

patrickkempff
Copy link
Contributor

@patrickkempff patrickkempff commented Nov 4, 2017

This pr adds documentation for the tintColor addition of #4590

Motivation

The tintColor was missing from the documentation but works perfectly fine.

Test Plan

Added a tintColor to showActionSheetWithOptions and showShareActionSheetWithOptions in the app i am building right now.

Release Notes

[DOCS][MINOR][ActionSheetIOS] - Added documentation for tintColor in ActionSheet.

This pr adds documentation for the tintColor addition of #4590
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@pull-bot
Copy link

pull-bot commented Nov 4, 2017

Warnings
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2017
@janicduplessis
Copy link
Contributor

Thanks for the fix!

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

I cannot do that @janicduplessis, because @patrickkempff does not have an active CLA on file.

@facebook facebook deleted a comment from eslint-bot Nov 5, 2017
@janicduplessis
Copy link
Contributor

@patrickkempff Could you sign the CLA please?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@patrickkempff
Copy link
Contributor Author

@janicduplessis
I had already signed the CLA, but somehow the bot did not pick that up. Anyway it has accepted my CLA singing!

@janicduplessis
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

I cannot do that @janicduplessis, because @patrickkempff does not have an active CLA on file.

@janicduplessis
Copy link
Contributor

Weird, it still doesn't pick it up. @hramos Could you check why it doesn't find the CLA entry?

@JoelMarcey
Copy link

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

I cannot do that @JoelMarcey, because @patrickkempff does not have an active CLA on file.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Nov 6, 2017
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

cdlewis pushed a commit to cdlewis/react-native that referenced this pull request Nov 19, 2017
Summary:
This pr adds documentation for the tintColor addition of facebook#4590

<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

The tintColor was missing from the documentation but works perfectly fine.

Added a tintColor to showActionSheetWithOptions and showShareActionSheetWithOptions in the app i am building right now.

[DOCS][MINOR][ActionSheetIOS] - Added documentation for tintColor in ActionSheet.
Closes facebook#16679

Differential Revision: D6248070

Pulled By: shergin

fbshipit-source-id: a2276f50b42ff2c5858008f3641c9607f248744a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants