-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add tintColor to ActionSheetIOS documentation #16679
Conversation
This pr adds documentation for the tintColor addition of #4590
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
Thanks for the fix! @facebook-github-bot shipit |
I cannot do that @janicduplessis, because @patrickkempff does not have an active CLA on file. |
@patrickkempff Could you sign the CLA please? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@janicduplessis |
@facebook-github-bot shipit |
I cannot do that @janicduplessis, because @patrickkempff does not have an active CLA on file. |
Weird, it still doesn't pick it up. @hramos Could you check why it doesn't find the CLA entry? |
@facebook-github-bot shipit |
I cannot do that @JoelMarcey, because @patrickkempff does not have an active CLA on file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This pr adds documentation for the tintColor addition of facebook#4590 <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> The tintColor was missing from the documentation but works perfectly fine. Added a tintColor to showActionSheetWithOptions and showShareActionSheetWithOptions in the app i am building right now. [DOCS][MINOR][ActionSheetIOS] - Added documentation for tintColor in ActionSheet. Closes facebook#16679 Differential Revision: D6248070 Pulled By: shergin fbshipit-source-id: a2276f50b42ff2c5858008f3641c9607f248744a
This pr adds documentation for the tintColor addition of #4590
Motivation
The tintColor was missing from the documentation but works perfectly fine.
Test Plan
Added a tintColor to showActionSheetWithOptions and showShareActionSheetWithOptions in the app i am building right now.
Release Notes
[DOCS][MINOR][ActionSheetIOS] - Added documentation for tintColor in ActionSheet.