Docs: Improve BackHandler documentation (addEventListener and removeEventListener) #16618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
adrianomelo
force-pushed
the
backhandler
branch
from
bb670c9 to
622d6a8
Compare
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Nov 7, 2017
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
cdlewis
pushed a commit
to cdlewis/react-native
that referenced
this pull request
Nov 19, 2017
…ventListener) Summary: This commit adds documentation to two methods of BackHandler API, addEventListener and removeEventListener. Despite being a simple change, it helps to keep the documentation consistent. I have tested the `./website` locally, the changes look similar to some other components such as `NetInfo`. [DOCS][ENHANCEMENT][BackHandler] - Improve BackHandler documentation (addEventListener and removeEventListener) Closes facebook#16618 Differential Revision: D6260935 Pulled By: hramos fbshipit-source-id: ab04a9fca89ddaa1925844b5754caf1c355a9329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This commit adds documentation to two methods of BackHandler API, addEventListener and removeEventListener. Despite being a simple change, it helps to keep the documentation consistent.
Test Plan
I have tested the
./websitelocally, the changes look similar to some other components such asNetInfo.Release Notes
[DOCS][ENHANCEMENT][BackHandler] - Improve BackHandler documentation (addEventListener and removeEventListener)