Delegate to ProgressBarAndroid from ActivityIndicator on Android, instead of the other way around

[brentvatne]

Motivation

ProgressBarAndroid regressed after fixing a bug in ccddbf8

Test Plan

Run this gist on a new project with this code: https://gist.github.com/brentvatne/a0b57e5bbae1bd2cf76765ea27f077af

Notice that you will see:

hmmm... doesn't seem right 🤔

With the patch in this PR applied, you will see:

oh! there we go 😄

Release Notes

[ANDROID] [BUGFIX] [ProgressBarAndroid] - Fix regression in ProgressBarAndroid which limited styleAttr to only Regular.

[pull-bot]

@facebook-github-bot label Core Team

Generated by 🚫 dangerJS

[bvaughn]

Did a quick smoke-test in Catalyst and this looks good to me. 👍

Thanks for this PR!

[ide]

@facebook-github-bot shipit

[facebook-github-bot]

@ide is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[bvaughn]

I didn't notice this while reviewing the code (since it wasn't part of the diff) but it looks like this changed introduced a bunch of deprecation warnings due to ProgressBarAndroid:

  componentDidMount() {
    if (this.props.indeterminate && this.props.styleAttr !== 'Horizontal') {
      console.warn(
        'Circular indeterminate `ProgressBarAndroid`' +
        'is deprecated. Use `ActivityIndicator` instead.'
      );
    }
  }

[bvaughn]

I will follow up on this internally.

Just a quick note though that for the time being, this change has been reverted (within Facebook) because it caused a bunch of yellow box deprecation warnings (the one I pointed out above) to be shown. I think the correct fix at this point is to re-land this change along with removing that deprecation warning, but I want to run this by others first to make sure there's no concerns with it.

[ide]

Brent has a commit up to fix the warning too. The longer-term fix we were thinking about is to split into three components, two that are public (ActivityIndicator and ProgressBar) that use a private third component underneath.

[bvaughn]

Might be easiest to just let me do that internally along with the rollback of the rollback, if you don't mind. (I've already started landing the diff anyway.)

[bvaughn]

Okay. The internal diff (D6092598) has landed re-adding this change and removing the deprecation message. It should sync to GitHub soon.