-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE in Android Switch during measure #16064
Conversation
see [Issue facebook#16000](facebook#16000) fix a null pointer exception while using higher version 'com.android.support:appcompat-v7'
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@4ndroidev Could you please sing CLA? |
@shengmin Sorry, I have already signed in CLA. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@4ndroidev I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
okey, what about ping? This is annoying :/ |
I believe this is also fixing #12359 |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
Looks good, sorry about the delay reviewing this! Just updated the PR title since that will be the commit message and added release notes. @facebook-github-bot shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Fixes #16000
see Issue #16000
fix a null pointer exception while using higher version 'com.android.support:appcompat-v7'
Test Plan
N/A
Release Notes
[ANDROID][BUGFIX][Switch] - Fix NPE in Android Switch during measure