Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in Android Switch during measure #16064

Closed
wants to merge 2 commits into from

Conversation

4ndroidev
Copy link
Contributor

@4ndroidev 4ndroidev commented Sep 22, 2017

Fixes #16000

see Issue #16000
fix a null pointer exception while using higher version 'com.android.support:appcompat-v7'

Test Plan

N/A

Release Notes

[ANDROID][BUGFIX][Switch] - Fix NPE in Android Switch during measure

see [Issue facebook#16000](facebook#16000) 
fix a null pointer exception while using higher version 'com.android.support:appcompat-v7'
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@shergin
Copy link
Contributor

shergin commented Oct 10, 2017

@4ndroidev Could you please sing CLA?

@4ndroidev
Copy link
Contributor Author

@shengmin Sorry, I have already signed in CLA.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@4ndroidev I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@Fortidude
Copy link

okey, what about ping? This is annoying :/

@hey99xx
Copy link

hey99xx commented Jan 25, 2018

I believe this is also fixing #12359

@pull-bot
Copy link

Warnings
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

@janicduplessis janicduplessis changed the title fix issue #16000 Fix NPE in Android Switch during measure, closes #16000 Jan 26, 2018
@janicduplessis janicduplessis changed the title Fix NPE in Android Switch during measure, closes #16000 Fix NPE in Android Switch during measure Jan 26, 2018
@janicduplessis
Copy link
Contributor

Looks good, sorry about the delay reviewing this!

Just updated the PR title since that will be the commit message and added release notes.

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 26, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

fr1n63 added a commit to fr1n63/react-native that referenced this pull request Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch of android will cause a NullPointerException
8 participants