Set host of development server for setupDevtools #15547
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
jhen0409
force-pushed
the
setup-devtools-host
branch
from
93db9be to
98a0aba
Compare
|
This would be awesome to have. In particular with https://github.com/jhen0409/react-native-debugger. Any update on this? |
jhen0409
force-pushed
the
setup-devtools-host
branch
from
454e206 to
ad3d582
Compare
jhen0409
force-pushed
the
setup-devtools-host
branch
from
ad3d582 to
54511f3
Compare
|
/cc @javache |
|
@jhen0409 I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
@javache is not working on RN anymore so we'll need to find somebody else to review this. |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@javache is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@javache is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
There was a problem hiding this comment.
@javache is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Related to facebook#15126, and this would be useful for use React DevTools on real device without modify `setupDevtools.js`. In Android emulator, the host of `SourceCode.scriptURL` is same with `PlatformConstants.ServerHost` so we can just replace it. * Tested on iOS device with [react-devtools](https://github.com/facebook/react-devtools/tree/master/packages/react-devtools) package. * Tested on Android emulator, the `getDevServer` module got the correctly hostname so that don't need `adb reverse`. [ENHANCEMENT] [setupDevtools] Set host of development server for setupDevtools Closes facebook#15547 Differential Revision: D6544980 Pulled By: javache fbshipit-source-id: a286874bcef0501c5d2e0be2251d58c236a5534a
|
Can someone merge it? |
|
It‘s extremly sad that this pr has been closed :( This is a very useful change, developing on a feal device is not unusual and sometimes the only way |
|
The PR appears as closed because RN is set up to sync to our internal repository. So all PRs are “closed” on GitHub when they’re imported, but the commits appear on master. |
react-native-bot
removed
the
Import Started
Related to #15126, and this would be useful for use React DevTools on real device without modify
setupDevtools.js.In Android emulator, the host of
SourceCode.scriptURLis same withPlatformConstants.ServerHostso we can just replace it.Test Plan
getDevServermodule got the correctly hostname so that don't needadb reverse.Release Notes
[ENHANCEMENT] [setupDevtools] Set host of development server for setupDevtools