Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out some common JavaScript code to scripts.js #14212

Closed
wants to merge 1 commit into from
Closed

Move out some common JavaScript code to scripts.js #14212

wants to merge 1 commit into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented May 27, 2017

Motivation (required)

Move reusable code into scripts.js

Test Plan (required)

Tested each of the documents locally.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels May 27, 2017
@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

This was referenced May 27, 2017
Closed
Closed
facebook-github-bot pushed a commit that referenced this pull request May 30, 2017
@hramos @facebook-github-bot
Only run tabbing logic on docs that contain blocks
ffa76d0 
Summary:
Builds upon #14212
Closes #14213

Differential Revision: D5149113

Pulled By: hramos

fbshipit-source-id: 99684bbb3bcae0e6061641373c6af7446729d7bd
facebook-github-bot pushed a commit that referenced this pull request May 30, 2017
@hramos @facebook-github-bot
Add support for syntax highlighting for languages other than JS
0a69356 
Summary:
The current website defaults to using JavaScript for any code block, regardless of language tag. This PR adds syntax highlighting support by passing the necessary language prop and by adding any missing languages to Marked.js.

Depends on #14212, #14065
Closes #14215

Differential Revision: D5149897

Pulled By: hramos

fbshipit-source-id: 95a817af2168d5743c75dd1ac030d399a68fb93c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hramos @facebook-github-bot