Fix sticky headers when rerendering #14012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ide
pushed a commit
to expo/react-native
that referenced
this pull request
May 24, 2017
Summary: There was an issue that sometimes sticky headers would stop moving when re-rendering because we did not reattach events properly. This makes sure that we always detach and reatach on rerender in case the scroll view ref changes. **Test plan** Tested that this fixes issues with sticky headers we discovered when updating Expo to RN 0.44. Closes facebook#14012 Differential Revision: D5094418 Pulled By: javache fbshipit-source-id: a56050ae786712e8a3de2a6e3b4e8749a2fde86e
ide
pushed a commit
to expo/react-native
that referenced
this pull request
May 30, 2017
Summary: There was an issue that sometimes sticky headers would stop moving when re-rendering because we did not reattach events properly. This makes sure that we always detach and reatach on rerender in case the scroll view ref changes. **Test plan** Tested that this fixes issues with sticky headers we discovered when updating Expo to RN 0.44. Closes facebook#14012 Differential Revision: D5094418 Pulled By: javache fbshipit-source-id: a56050ae786712e8a3de2a6e3b4e8749a2fde86e
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 7, 2017
Summary: There was an issue that sometimes sticky headers would stop moving when re-rendering because we did not reattach events properly. This makes sure that we always detach and reatach on rerender in case the scroll view ref changes. **Test plan** Tested that this fixes issues with sticky headers we discovered when updating Expo to RN 0.44. Closes facebook#14012 Differential Revision: D5094418 Pulled By: javache fbshipit-source-id: a56050ae786712e8a3de2a6e3b4e8749a2fde86e
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 7, 2017
Summary: There was an issue that sometimes sticky headers would stop moving when re-rendering because we did not reattach events properly. This makes sure that we always detach and reatach on rerender in case the scroll view ref changes. **Test plan** Tested that this fixes issues with sticky headers we discovered when updating Expo to RN 0.44. Closes facebook#14012 Differential Revision: D5094418 Pulled By: javache fbshipit-source-id: a56050ae786712e8a3de2a6e3b4e8749a2fde86e
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 10, 2017
Summary: There was an issue that sometimes sticky headers would stop moving when re-rendering because we did not reattach events properly. This makes sure that we always detach and reatach on rerender in case the scroll view ref changes. **Test plan** Tested that this fixes issues with sticky headers we discovered when updating Expo to RN 0.44. Closes facebook#14012 Differential Revision: D5094418 Pulled By: javache fbshipit-source-id: a56050ae786712e8a3de2a6e3b4e8749a2fde86e
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Jun 14, 2017
Summary: There was an issue that sometimes sticky headers would stop moving when re-rendering because we did not reattach events properly. This makes sure that we always detach and reatach on rerender in case the scroll view ref changes. **Test plan** Tested that this fixes issues with sticky headers we discovered when updating Expo to RN 0.44. Closes facebook#14012 Differential Revision: D5094418 Pulled By: javache fbshipit-source-id: a56050ae786712e8a3de2a6e3b4e8749a2fde86e
mikelambert
pushed a commit
to mikelambert/react-native
that referenced
this pull request
Jun 17, 2017
Summary: There was an issue that sometimes sticky headers would stop moving when re-rendering because we did not reattach events properly. This makes sure that we always detach and reatach on rerender in case the scroll view ref changes. **Test plan** Tested that this fixes issues with sticky headers we discovered when updating Expo to RN 0.44. Closes facebook#14012 Differential Revision: D5094418 Pulled By: javache fbshipit-source-id: a56050ae786712e8a3de2a6e3b4e8749a2fde86e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue that sometimes sticky headers would stop moving when re-rendering because we did not reattach events properly. This makes sure that we always detach and reatach on rerender in case the scroll view ref changes.
Test plan
Tested that this fixes issues with sticky headers we discovered when updating Expo to RN 0.44.