Add description to require a key for each child in ViewPageAndroid #13829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the header description and example code.
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
GH Review: accepted
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
and removed
Import Started
facebook-github-bot
added
the
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@HuyAnhh I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
|
@hramos Is there a problem with the pull request? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 13, 2018
Summary: @public This sync includes the following changes: - **[4773fdf7c](facebook/react@4773fdf7c)**: Deprecate findDOMNode in StrictMode (#13841) //<Sebastian Markbåge>// - **[c9be16f5b](facebook/react@c9be16f5b)**: [scheduler] Rename priority levels (#13842) //<Andrew Clark>// - **[3b7ee2692](facebook/react@3b7ee2692)**: Deprecate context object as a consumer and add a warning message (#13829) //<Dominic Gannaway>// - **[8ca8a594e](facebook/react@8ca8a594e)**: Error gracefully for unsupported SSR features (#13839) //<Dan Abramov>// - **[4a635785f](facebook/react@4a635785f)**: Fix User Timing oddities with Suspense, pure, and lazy (#13833) //<Dan Abramov>// - **[a165cf747](facebook/react@a165cf747)**: Renamed 4 Internal React Modules //<Nadia Osipova>// - **[a68ca9a5b](facebook/react@a68ca9a5b)**: React.pure automatically forwards ref (#13822) //<Sophie Alpert>// - **[c73497c3c](facebook/react@c73497c3c)**: Update bundle sizes for 16.6.0-alpha.8af6728 release //<Dan Abramov>// - **[1a57dc668](facebook/react@1a57dc668)**: Updating dependencies for react-noop-renderer //<Dan Abramov>// - **[77f8dfd81](facebook/react@77f8dfd81)**: Updating package versions for release 16.6.0-alpha.8af6728 //<Dan Abramov>// - **[8af6728c6](facebook/react@8af6728c6)**: Enable Suspense + rename Placeholder (#13799) //<Dan Abramov>// - **[f47a958ea](facebook/react@f47a958ea)**: Don’t add onclick listener to React root (#13778) //<Philipp>// - **[b2cea9078](facebook/react@b2cea9078)**: [scheduler] Eagerly schedule rAF at beginning of frame (#13785) //<Andrew Clark>// - **[e2e7cb9f4](facebook/react@e2e7cb9f4)**: [scheduler] add a test documenting current behavior (#13687) //<plievone>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions d836010...4773fdf Reviewed By: acdlite Differential Revision: D10350869 fbshipit-source-id: ea8ad4b5d914c870be1fc80aa1005b224d37f5e5
kelset
pushed a commit
that referenced
this pull request
Nov 9, 2018
Summary: @public This sync includes the following changes: - **[4773fdf7c](facebook/react@4773fdf7c)**: Deprecate findDOMNode in StrictMode (#13841) //<Sebastian Markbåge>// - **[c9be16f5b](facebook/react@c9be16f5b)**: [scheduler] Rename priority levels (#13842) //<Andrew Clark>// - **[3b7ee2692](facebook/react@3b7ee2692)**: Deprecate context object as a consumer and add a warning message (#13829) //<Dominic Gannaway>// - **[8ca8a594e](facebook/react@8ca8a594e)**: Error gracefully for unsupported SSR features (#13839) //<Dan Abramov>// - **[4a635785f](facebook/react@4a635785f)**: Fix User Timing oddities with Suspense, pure, and lazy (#13833) //<Dan Abramov>// - **[a165cf747](facebook/react@a165cf747)**: Renamed 4 Internal React Modules //<Nadia Osipova>// - **[a68ca9a5b](facebook/react@a68ca9a5b)**: React.pure automatically forwards ref (#13822) //<Sophie Alpert>// - **[c73497c3c](facebook/react@c73497c3c)**: Update bundle sizes for 16.6.0-alpha.8af6728 release //<Dan Abramov>// - **[1a57dc668](facebook/react@1a57dc668)**: Updating dependencies for react-noop-renderer //<Dan Abramov>// - **[77f8dfd81](facebook/react@77f8dfd81)**: Updating package versions for release 16.6.0-alpha.8af6728 //<Dan Abramov>// - **[8af6728c6](facebook/react@8af6728c6)**: Enable Suspense + rename Placeholder (#13799) //<Dan Abramov>// - **[f47a958ea](facebook/react@f47a958ea)**: Don’t add onclick listener to React root (#13778) //<Philipp>// - **[b2cea9078](facebook/react@b2cea9078)**: [scheduler] Eagerly schedule rAF at beginning of frame (#13785) //<Andrew Clark>// - **[e2e7cb9f4](facebook/react@e2e7cb9f4)**: [scheduler] add a test documenting current behavior (#13687) //<plievone>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions d836010...4773fdf Reviewed By: acdlite Differential Revision: D10350869 fbshipit-source-id: ea8ad4b5d914c870be1fc80aa1005b224d37f5e5
ferrannp
pushed a commit
to ferrannp/react-native-viewpager
that referenced
this pull request
Feb 8, 2019
Summary: Change the header description and example code. Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. What existing problem does the pull request solve? Clarify extra requirements for a Component. A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. Go to documentation, see changes. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines. [1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9 [2]: https://code.facebook.com/cla [3]: https://travis-ci.org/facebook/react-native [4]: http://circleci.com/gh/facebook/react-native [5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests Closes facebook/react-native#13829 Differential Revision: D5661106 Pulled By: hramos fbshipit-source-id: 39736c05f8017009cdd637930c9f89ae6c2ee7c3
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: @public This sync includes the following changes: - **[4773fdf7c](facebook/react@4773fdf7c)**: Deprecate findDOMNode in StrictMode (facebook#13841) //<Sebastian Markbåge>// - **[c9be16f5b](facebook/react@c9be16f5b)**: [scheduler] Rename priority levels (facebook#13842) //<Andrew Clark>// - **[3b7ee2692](facebook/react@3b7ee2692)**: Deprecate context object as a consumer and add a warning message (facebook#13829) //<Dominic Gannaway>// - **[8ca8a594e](facebook/react@8ca8a594e)**: Error gracefully for unsupported SSR features (facebook#13839) //<Dan Abramov>// - **[4a635785f](facebook/react@4a635785f)**: Fix User Timing oddities with Suspense, pure, and lazy (facebook#13833) //<Dan Abramov>// - **[a165cf747](facebook/react@a165cf747)**: Renamed 4 Internal React Modules //<Nadia Osipova>// - **[a68ca9a5b](facebook/react@a68ca9a5b)**: React.pure automatically forwards ref (facebook#13822) //<Sophie Alpert>// - **[c73497c3c](facebook/react@c73497c3c)**: Update bundle sizes for 16.6.0-alpha.8af6728 release //<Dan Abramov>// - **[1a57dc668](facebook/react@1a57dc668)**: Updating dependencies for react-noop-renderer //<Dan Abramov>// - **[77f8dfd81](facebook/react@77f8dfd81)**: Updating package versions for release 16.6.0-alpha.8af6728 //<Dan Abramov>// - **[8af6728c6](facebook/react@8af6728c6)**: Enable Suspense + rename Placeholder (facebook#13799) //<Dan Abramov>// - **[f47a958ea](facebook/react@f47a958ea)**: Don’t add onclick listener to React root (facebook#13778) //<Philipp>// - **[b2cea9078](facebook/react@b2cea9078)**: [scheduler] Eagerly schedule rAF at beginning of frame (facebook#13785) //<Andrew Clark>// - **[e2e7cb9f4](facebook/react@e2e7cb9f4)**: [scheduler] add a test documenting current behavior (facebook#13687) //<plievone>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions d836010...4773fdf Reviewed By: acdlite Differential Revision: D10350869 fbshipit-source-id: ea8ad4b5d914c870be1fc80aa1005b224d37f5e5
james-watkin
added a commit
to james-watkin/react-native-pager-view
that referenced
this pull request
Dec 28, 2021
Summary: Change the header description and example code. Thanks for submitting a PR! Please read these instructions carefully: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. What existing problem does the pull request solve? Clarify extra requirements for a Component. A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more. Go to documentation, see changes. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines. [1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9 [2]: https://code.facebook.com/cla [3]: https://travis-ci.org/facebook/react-native [4]: http://circleci.com/gh/facebook/react-native [5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests Closes facebook/react-native#13829 Differential Revision: D5661106 Pulled By: hramos fbshipit-source-id: 39736c05f8017009cdd637930c9f89ae6c2ee7c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the header description and example code.
Thanks for submitting a PR! Please read these instructions carefully:
masterbranch, NOT a "stable" branch.Motivation (required)
What existing problem does the pull request solve?
Clarify extra requirements for a Component.
Test Plan (required)
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.
Go to documentation, see changes.
If you have added code that should be tested, add tests.
Next Steps
Sign the CLA, if you haven't already.
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.