[ActivityIndicator] Specify a width #1156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
👍 |
ide
force-pushed
the
activity-indicator-width
branch
2 times, most recently
from
16c18dc to
e69d2f6
Compare
The activity indicator was treated as a zero-width element without an explicit width. Fill it in so the style dimensions match what is displayed on the screen. Test Plan: Render an ActivityIndicator with a background, and see that the background shows up as a square behind the spinner instead of not showing up at all (since it was 0px wide previously).
ide
force-pushed
the
activity-indicator-width
branch
from
e69d2f6 to
abdacb9
Compare
|
This is probably going to break many of our internal apps, the person that imports it needs to review it carefully |
|
I briefly went through the Ads Manager and all of the spinners I found were horizontally centered so I don't expect this diff to expect them. Also they were custom spinners so I don't think they even use this component. In the groups app there's a spinner on the home screen, also horizontally centered. The only places where this diff would have an effect is if the spinners were positioned next to other components. |
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1428484607458625/int_phab to review. |
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
May 13, 2022
Factor out dependency download task so it can be shared across pipelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The activity indicator was treated as a zero-width element without an explicit width. Fill it in so the style dimensions match what is displayed on the screen.
Test Plan: Render an ActivityIndicator with a background, and see that the background shows up as a square behind the spinner instead of not showing up at all (since it was 0px wide previously).