-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PermissionsAndroid] Handle "Never Ask Again" in permissions and add requestMultiplePermissions #10221
Closed
Closed
[PermissionsAndroid] Handle "Never Ask Again" in permissions and add requestMultiplePermissions #10221
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4e8fcb9
Update permissions to handle 'Never Ask Again' case and add multiple …
cmcewen 5b0c28c
Update Permissions example and bump targetSdkVersion to 23
cmcewen 1e7e69f
Merge branch 'master' into permissions-update
cmcewen 053d2b8
Merge branch 'master' into permissions-update
cmcewen 0b83011
Change flow types
cmcewen 8d2c4b3
Update API to use web permissision API syntax
cmcewen e6a6378
Fix docs for old requestPermission
cmcewen dfb1125
Add deprecation warnings
cmcewen bec452a
Change Permissions method name to check and add proper flow types
cmcewen 27cf4e8
Change query to check in example
cmcewen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,7 @@ type Rationale = { | |
* 'so you can take awesome pictures.' | ||
* } | ||
* ) | ||
* if (granted) { | ||
* if (granted === PermissionsAndroid.RESULTS.PERMISSION_GRANTED) { | ||
* console.log("You can use the camera") | ||
* } else { | ||
* console.log("Camera permission denied") | ||
|
@@ -61,6 +61,7 @@ type Rationale = { | |
|
||
class PermissionsAndroid { | ||
PERMISSIONS: Object; | ||
RESULTS: Object; | ||
|
||
constructor() { | ||
/** | ||
|
@@ -92,6 +93,12 @@ class PermissionsAndroid { | |
READ_EXTERNAL_STORAGE: 'android.permission.READ_EXTERNAL_STORAGE', | ||
WRITE_EXTERNAL_STORAGE: 'android.permission.WRITE_EXTERNAL_STORAGE', | ||
}; | ||
|
||
this.RESULTS = { | ||
PERMISSION_GRANTED: 'PERMISSION_GRANTED', | ||
PERMISSION_DENIED: 'PERMISSION_DENIED', | ||
PERMISSION_NEVER_ASK_AGAIN: 'PERMISSION_NEVER_ASK_AGAIN', | ||
}; | ||
} | ||
|
||
/** | ||
|
@@ -104,7 +111,7 @@ class PermissionsAndroid { | |
|
||
/** | ||
* Prompts the user to enable a permission and returns a promise resolving to a | ||
* boolean value indicating whether the user allowed or denied the request | ||
* string value indicating whether the user allowed or denied the request | ||
* | ||
* If the optional rationale argument is included (which is an object with a | ||
* `title` and `message`), this function checks with the OS whether it is | ||
|
@@ -128,6 +135,15 @@ class PermissionsAndroid { | |
} | ||
return Permissions.requestPermission(permission); | ||
} | ||
|
||
/** | ||
* Prompts the user to enable multiple permissions in the same dialog and | ||
* returns an object with the permissions as keys and strings as values | ||
* indicating whether the user allowed or denied the request | ||
*/ | ||
requestMultiplePermissions(permissions: Array<string>) : Promise<Object> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Specify a stricter flow return type:
|
||
return Permissions.requestMultiplePermissions(permissions); | ||
} | ||
} | ||
|
||
PermissionsAndroid = new PermissionsAndroid(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change flow return type from
Promise<boolean>
toPromise<string>
Will at least warn people using flow that this api has changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although because this is javascript,
if (granted) {
will just evaluate as true if granted is a non empty string. So we won't get a a flow warning.