Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let backgroundColor overflow past borderRadius #9494

Closed
lorensr opened this issue Aug 20, 2016 · 7 comments
Closed

Don't let backgroundColor overflow past borderRadius #9494

lorensr opened this issue Aug 20, 2016 · 7 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@lorensr
Copy link

lorensr commented Aug 20, 2016

Re-opening #904, note the orange corners that shouldn't be there:

image

Should be:

image

overflow: 'hidden' fixes it, but it should not be needed – not showing the backgroundColor should be the default behavior.

v0.31.0, mac, iOS

@geirman
Copy link
Contributor

geirman commented Sep 7, 2016

@lorensr you're probably right, this should be fixed without relying on the overflow: 'hidden' work around. At the very least, we should mention this in the docs. React native is a community project and so we rely on the community to help improve things. Would you be willing to submit a PR that either fixes this properly or at least updates the docs to help others understand the work around?

@lorensr
Copy link
Author

lorensr commented Sep 7, 2016

Don't have time right now, but whereabouts in the code would the fix be?

On Wednesday, September 7, 2016, Chris Geirman [email protected]
wrote:

@lorensr https://github.com/lorensr you're probably right, this should
be fixed without relying on the overflow: 'hidden' work around. At the
very least, we should mention this in the docs. React native is a community
project and so we rely on the community to help improve things. Would you
be willing to submit a PR that either fixes this properly or at least
updates the docs to help others understand the work around?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9494 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPVmJXY2J6VZ5qEORB5BlkIpsqLyobGks5qnzTmgaJpZM4JpKLu
.

@geirman
Copy link
Contributor

geirman commented Sep 7, 2016

¯\_(ツ)_/¯

@charpeni
Copy link
Contributor

@facebook-github-bot label Icebox

@charpeni
Copy link
Contributor

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/dont-let-backgroundcolor-overflow-past-borderradius

ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.

Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@charpeni
Copy link
Contributor

@facebook-github-bot close

@facebook-github-bot facebook-github-bot added Icebox Ran Commands One of our bots successfully processed a command. labels Nov 14, 2016
@facebook-github-bot
Copy link
Contributor

@charpeni tells me to close this issue. If you think it should still be opened let us know why.

@facebook-github-bot facebook-github-bot added the Ran Commands One of our bots successfully processed a command. label Nov 14, 2016
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants