Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Networking page links to navigators / next page are broken #8611

Closed
valscion opened this issue Jul 6, 2016 · 1 comment
Closed

Documentation: Networking page links to navigators / next page are broken #8611

valscion opened this issue Jul 6, 2016 · 1 comment
Assignees
@hramos
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@valscion
Copy link
Contributor

valscion commented Jul 6, 2016

http://facebook.github.io/react-native/releases/next/docs/network.html

  1. To manage the transition between these screens, you will need to learn about navigators.

    This "navigators" links is broken and instead redirects to the documentation front page.

  2. The "Next →" link is also broken on that page

I'm just following the We Need Your Help instructions here 😄
@charpeni
Copy link
Contributor

charpeni commented Jul 6, 2016

@facebook-github-bot label Documentation

@ghost ghost added Documentation Ran Commands One of our bots successfully processed a command. labels Jul 6, 2016
@hramos hramos mentioned this issue Jul 11, 2016
Closed
@ghost ghost closed this as completed in b33424e Jul 11, 2016
bestander pushed a commit that referenced this issue Jul 12, 2016
@JoelMarcey @bestander
Cherry-pick: Fix Navigation Links (#8703)
eb55b99 
* Introduce navigators in the tutorial

Summary:
Adds a new section to the tutorial. Covers the basics of scenes and navigators.

The navigator comparison doc has been moved to docs/navigation.html in this PR.

![navigators](https://cloud.githubusercontent.com/assets/165856/16505919/37459e3a-3ed4-11e6-87e9-5fa7e6f792d3.png)
Closes #8515

Differential Revision: D3507325

Pulled By: caabernathy

fbshipit-source-id: e9ee5b2572868189af198cdf461b2728dfa84f9e

* Fix links from networking to navigation in The Basics.

Summary:
Fixes #8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes #8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
bestander pushed a commit that referenced this issue Jul 12, 2016
@JoelMarcey @bestander
Fix links from networking to navigation in The Basics. (#8715)
e0f4fd5 
Summary:
Fixes #8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes #8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
samerce pushed a commit to iodine/react-native that referenced this issue Aug 23, 2016
@hramos @samerce
Fix links from networking to navigation in The Basics.
9485c0e 
Summary:
Fixes facebook#8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes facebook#8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
mpretty-cyro pushed a commit to HomePass/react-native that referenced this issue Aug 25, 2016
@hramos
Fix links from networking to navigation in The Basics.
0e53d09 
Summary:
Fixes facebook#8611.

Once this lands, we may want to cherry-pick it into 0.29 to fix the broken links.
Closes facebook#8698

Differential Revision: D3544388

Pulled By: JoelMarcey

fbshipit-source-id: d5132b112e3079d1fd9ab6d84ff1a4328bee871f
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hramos hramos

Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Documentation] Fix links from networking to navigation in The Basics.
4 participants
@hramos @valscion @charpeni @react-native-bot