-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] RN 0.76 stretches Modal
to full screen on Android API < 30 if edge-to-edge mode is enabled
#47307
Labels
0.76
Component: Modal
Impact: Regression
Describes a behavior that used to work on a prior release, but stopped working recently.
Issue: Author Provided Repro
This issue can be reproduced in Snack or an attached project.
Newer Patch Available
Platform: Android
Android applications.
Resolution: PR Submitted
A pull request with a fix has been provided.
Comments
|
react-native-bot
added
Component: Modal
Impact: Regression
Describes a behavior that used to work on a prior release, but stopped working recently.
Platform: Android
Android applications.
labels
Oct 30, 2024
|
2 tasks
cortinico
added
0.76
Issue: Author Provided Repro
This issue can be reproduced in Snack or an attached project.
and removed
Needs: Triage 🔍
labels
Oct 30, 2024
alanleedev
added a commit
to alanleedev/react-native
that referenced
this issue
Oct 31, 2024
Summary: Fixing issue raised in facebook#47307 This is a follow up from D62286026. It appears there was a line that went missing while trying to refactor the code. `fitsSystemWindows = true` is needeod for < API 30 to avoid content rendering under the system bars when Modal is shown with Activity that is edge-to-edge. Differential Revision: D65280014
alanleedev
added a commit
to alanleedev/react-native
that referenced
this issue
Oct 31, 2024
Summary: Fixing issue raised in facebook#47307 This is a follow up from D62286026. It appears there was a line that went missing while trying to refactor the code. `fitsSystemWindows = true` is needeod for < API 30 to avoid content rendering under the system bars when Modal is shown with Activity that is edge-to-edge. Changelog: [Android][Fixed] Fix Regression - Modal content rendering below system bar on < API 30 when activity is edge-to-edge Differential Revision: D65280014
alanleedev
added a commit
to alanleedev/react-native
that referenced
this issue
Nov 1, 2024
…facebook#47339) Summary: Fixing issue raised in facebook#47307 This is a follow up from D62286026. It appears there was a line that went missing while trying to refactor the code. `fitsSystemWindows = true` is needeod for < API 30 to avoid content rendering under the system bars when Modal is shown with Activity that is edge-to-edge. Changelog: [Android][Fixed] Fix Regression - Modal content rendering below system bar on < API 30 when activity is edge-to-edge Reviewed By: cortinico Differential Revision: D65280014
facebook-github-bot
pushed a commit
that referenced
this issue
Nov 1, 2024
…#47339) Summary: Pull Request resolved: #47339 Fixing issue raised in #47307 This is a follow up from D62286026. It appears there was a line that went missing while trying to refactor the code. `fitsSystemWindows = true` is needeod for < API 30 to avoid content rendering under the system bars when Modal is shown with Activity that is edge-to-edge. Changelog: [Android][Fixed] Fix Regression - Modal content rendering below system bar on < API 30 when activity is edge-to-edge Reviewed By: cortinico Differential Revision: D65280014 fbshipit-source-id: 616ff739be55635f1295ef3bf8b997a27ef769ae
migueldaipre
added
the
Resolution: PR Submitted
A pull request with a fix has been provided.
label
Nov 1, 2024
blakef
pushed a commit
that referenced
this issue
Nov 12, 2024
…#47339) Summary: Pull Request resolved: #47339 Fixing issue raised in #47307 This is a follow up from D62286026. It appears there was a line that went missing while trying to refactor the code. `fitsSystemWindows = true` is needeod for < API 30 to avoid content rendering under the system bars when Modal is shown with Activity that is edge-to-edge. Changelog: [Android][Fixed] Fix Regression - Modal content rendering below system bar on < API 30 when activity is edge-to-edge Reviewed By: cortinico Differential Revision: D65280014 fbshipit-source-id: 616ff739be55635f1295ef3bf8b997a27ef769ae
@JacksonHonoro Could you provide screenshots and Reproducer ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0.76
Component: Modal
Impact: Regression
Describes a behavior that used to work on a prior release, but stopped working recently.
Issue: Author Provided Repro
This issue can be reproduced in Snack or an attached project.
Newer Patch Available
Platform: Android
Android applications.
Resolution: PR Submitted
A pull request with a fix has been provided.
Description
If edge-to-edge mode is enabled for the app:
And Modal is shown, then we have a different behavior (see steps for reproduction and screenshots section).
Prior to RN 0.75 we had a consistent behavior and content was always shown above the navigation bar (independently from MainActivity configuration). I hope to get this consistent behavior in RN 0.76 as well. If we want to customize navigation bar behavior (and draw a content behind them) we can take a power of this PR: #47254
So keeping all information above in the head I tend to think that this is a regression 🙂
Steps to reproduce
React Native Version
0.76.1
Affected Platforms
Runtime - Android
Output of
npx react-native info
Stacktrace or Logs
Reproducer
https://github.com/kirillzyusko/react-native-modal-edge-to-edge-issue
Screenshots and Videos
The text was updated successfully, but these errors were encountered: